V3 core sdk via nuget #3533
Merged
V3 core sdk via nuget #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhathcock
commented
Jun 25, 2024
| @@ -19,7 +19,6 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.0" /> | |||
| <PackageReference Include="Speckle.AutoCAD.API" Version="2024.0.0" /> | |||
There was a problem hiding this comment.
@clairekuang is this okay?
BovineOx
approved these changes
Jun 27, 2024
| @@ -404,7 +434,7 @@ | |||
| "dependencies": { | |||
| "Serilog.Extensions.Logging": "[7.0.0, )", | |||
| "Speckle.Autofac": "[2.0.999-local, )", | |||
| "Speckle.Core": "[2.0.999-local, )" | |||
| "Speckle.Core": "[3.0.1-alpha.11, )" | |||
There was a problem hiding this comment.
Should we have some rules around what we should pick up? i.e. accept minor versions and bug fixes? Maybe this isn't the right place and we perhaps don't need to do it right away
|
I mean it's all a bit hard to read but updating reference to the nuget essentially, mainly just:
I did have another but it's gone... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spockle.atlassian.net/browse/DUI3-35
takes the intermediate step of referencing core from the new repo and removing core from the solution filter.
Some changes to logging help with dependencies